Skip to content

Add support for DCN adoption #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
olliewalsh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for DCN adoption #670

olliewalsh wants to merge 1 commit into from
+2,854 −0

Conversation

@olliewalsh
Copy link

@olliewalsh olliewalsh commented Dec 17, 2025

Add a DT for DCN with no (local) storage, used for DCN adoption testing.
Based on the existing DCN example and the HCI VA where adoption was already supported.

@olliewalsh
Add support for DCN adoption
34ee8ff 
Add a DT for DCN with no (local) storage, used for DCN adoption testing.
Based on the existing DCN example and the HCI VA where adoption was already
supported.

Signed-off-by: Oliver Walsh <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olliewalsh
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh olliewalsh requested a review from fultonj December 17, 2025 15:27
@fultonj fultonj added ready-review Request is ready to be reviewed and removed do-not-merge/work-in-progress labels Jan 8, 2026
@fultonj fultonj marked this pull request as ready for review January 8, 2026 12:49
@openshift-ci openshift-ci bot requested a review from cjeanner January 8, 2026 12:49
@fultonj fultonj removed the request for review from cjeanner January 8, 2026 12:52
@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2026

@olliewalsh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 34ee8ff link true /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fultonj fultonj mentioned this pull request Jan 8, 2026
Merged
@fultonj
Copy link
Contributor

fultonj commented Jan 12, 2026 •
edited
Loading

I've been testing this and I have some ideas for it that I'm testing. I'll follow up. Putting it on hold for now. Feel free to let me know if there are concerns.

@fultonj fultonj added do-not-merge/hold and removed ready-review Request is ready to be reviewed labels Jan 12, 2026
@fultonj
Copy link
Contributor

fultonj commented Jan 15, 2026

The following is a possible alternative to this patch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fultonj fultonj Awaiting requested review from fultonj

Assignees

No one assigned

Labels

do-not-merge/hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olliewalsh @fultonj